Repository navigation
Conversation
This was referenced Oct 22, 2026
Closed
Open
dayfine
force-pushed
the
bbq/failure-screenshots
branch
from
October 27, 2026 06:12
f07244e to
e1d2a2d
Compare
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 27, 2026 06:12
0ceac54 to
c8ba680
Compare
dayfine
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 28, 2026 03:35
c8ba680 to
7d24d5f
Compare
dayfine
force-pushed
the
bbq/failure-screenshots
branch
from
October 28, 2026 03:35
e1d2a2d to
72099ba
Compare
When a catch quest times out entering battle, or a quest is still on the panel after an attempt, the logs say what failed but not what the screen showed. Add save_bbq_snapshot(), which saves the current frame to DEBUG_PATH()/BBQ/ as <timestamp>-<quest>-<reason>.png and logs a "BBQ event=snapshot" line with the outcome. Unlike dump_image(), it stays on the local machine and sends nothing to telemetry. Call it at the battle-entry timeout and at failed quest verification. Add PokemonSV::BBQSnapshot tests that save into a folder that does not exist yet and check the file, path and log line, and that check a save that cannot be written returns no path and logs saved=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/diagnostics-and-baseline
branch
from
October 28, 2026 08:08
7d24d5f to
7cf661b
Compare
dayfine
force-pushed
the
bbq/failure-screenshots
branch
from
October 28, 2026 08:08
72099ba to
cc69593
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Keep screenshot evidence in its own adapter, without duplicating canonical status events. Move both screenshot regressions beside the snapshot module as explicit input/expectation cases and preserve retry/controller decisions.
…to integration/bbq-screenshots-consolidated
This was referenced Nov 6, 2026
…to integration/bbq-screenshots-consolidated
Propagate the user-directed legacy-size exception when merging the dispatcher restoration from #2. Only the existing file/function size findings remain: 1467 versus 1463 lines and 138 versus 135 lines. Do not relax global linter policy or introduce dispatch refactors for this diagnostics change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
bbq/diagnostics-and-baseline(#2), including #27's consolidated logging. This diff adds local failure-screenshot evidence.When battle entry times out or a quest remains on the board after verification, save the current frame locally under
DEBUG_PATH()/BBQ/and log its path. No telemetry is sent. The snapshot adapter reuses #2's canonical timeout/result events. The existing unsplit dispatcher retains all retry/counting decisions and controller inputs. Both screenshot tests remain beside the snapshot module and register through the BBQ suite.These images are developer/bug-report evidence, currently captured automatically. Before normal-user release, choose lab-only handling or explicit opt-in defaulting off. This distribution decision and the separate #19 capture overlap remain follow-ups; no new setting is implemented here.
Current head
2f6af0a14merges #2's user-directed removal of the execution split and follows its scoped legacy-size waiver. The only two code-health findings are the same existing file/function sizes (1467 versus 1463 lines and 138 versus 135 lines); they are accepted as the consequence of retaining the existing dispatcher, not reported as green. Other code-health and whitespace checks pass. Fresh native CI is running; earlier native results atd29f79bd5remain historical. No console run.